-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Utilities page design to align with designer feedback #2905
Conversation
HorizontalAlignment="Center" | ||
IsOn="{x:Bind ViewModel.LaunchAsAdmin, Mode=TwoWay}" | ||
Visibility="{x:Bind ViewModel.LaunchAsAdminVisibility, Mode=OneWay}" | ||
OnContent="Launch as administrator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both On and Off use the same content? This tells me that the program will still launch as admin even when toggled off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, it is like - turn it on to launch as admin. i.e. to me, the text doesn't represent the current state of the switch but what would happen if turn it on.
f921f07
to
a9c6053
Compare
* strings and url * visibility * pr feedback * pr feedback * string and icon * merge conflict --------- Co-authored-by: Darshak Bhatti <dabhatti@micorsoft.com>
Summary of the pull request
This PR updates design of utilities page to remove the split button and add a toggle for admin launch. This change also updates descriptions to strings written by the content writer and links to go links instead of aka.ms.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Manually validated
PR checklist